fix: Use registerCallableModule API for React Native 0.79+ New Architecture compatibility #1
+46
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecture compatibility Replace BatchedBridge.registerCallableModule with the new registerCallableModule API from react-native/Libraries/Core/registerCallableModule.js. This fixes the 'BatchedBridge.registerCallableModule is not a function' error that occurs on React Native 0.79+ when the New Architecture (Bridgeless mode) is enabled. The new API works with both the old bridge and the New Architecture. Co-Authored-By: brooklyn@carepilot.com <brooklyn@carepilot.com>
Author
Original prompt from brooklyn |
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…TATE permission - Use AudioManager.OnAudioFocusChangeListener instead of PhoneStateListener - Remove READ_PHONE_STATE and READ_CALL_LOG permissions from AndroidManifest.xml - Remove permission requests from Expo config plugin - This avoids TelephonyPermissions crashes on Android 10+ where READ_PHONE_STATE requires runtime permission that may not be granted The AudioManager approach detects audio focus changes (like when a phone call takes audio focus) without requiring sensitive phone state permissions. Co-Authored-By: brooklyn@carepilot.com <brooklyn@carepilot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
BatchedBridge.registerCallableModule is not a functionerror that occurs on React Native 0.79+ when the New Architecture (Bridgeless mode) is enabled by default.The fix replaces the old
BatchedBridge.registerCallableModuleAPI with the newregisterCallableModuleAPI fromreact-native/Libraries/Core/registerCallableModule.js. This new API internally detects whether Bridgeless mode is active and uses the appropriate registration method, making it compatible with both the old bridge and the New Architecture.Review & Testing Checklist for Human
Test Plan
yarn installandyarn prebuild:cleanNotes
This change is required for the mobile-app Expo SDK 53 upgrade (CP-3384). The New Architecture is enabled by default in Expo SDK 53, and the old
BatchedBridge.registerCallableModulemethod doesn't exist in Bridgeless mode.Link to Devin run: https://app.devin.ai/sessions/466ac199cd7342529b5e1dd390b072d2
Requested by: @brooklynrauckman