Switch from 'lzma' to 'lzma-native' for a free ~4x speedup #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for your PR. I don't want native dependencies as they're a pain to install, and lzma isn't used enough for a performance improvement to really matter anyway. |
Contributor
Author
|
It's literally a night and day difference for my depot installer... |
Owner
|
I see. I still don’t want to add a native dependency for such a relatively niche need but I think it would be fine if it’s an optional dependency and used if present, as long as the consumer manually installs it. I’ll change it up to be an optional peer dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.