Skip to content

mail: get_attachments returns correct filename when it is specified in content_type#200

Closed
romsahel wants to merge 1 commit intoDockYard:masterfrom
romsahel:mail-get-attachments-fix-filename-in-content-type-1
Closed

mail: get_attachments returns correct filename when it is specified in content_type#200
romsahel wants to merge 1 commit intoDockYard:masterfrom
romsahel:mail-get-attachments-fix-filename-in-content-type-1

Conversation

@romsahel
Copy link
Copy Markdown
Contributor

@romsahel romsahel commented Jul 11, 2025

Changes proposed in this pull request

Found in production, an e-mail with the following part:

Content-Type: application/octet-stream; name="document.pdf"
Content-Transfer-Encoding: base64
Content-Disposition: attachment

Currently, this returns filename "Unknown" since there is no filename property in :content_disposition.
This issue handles the case where the name is specified in :content_type instead.

@andrewtimberlake
Copy link
Copy Markdown
Collaborator

Thank you, added in a6b537b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants