add failing test for custom headers in multipart message#198
Closed
romsahel wants to merge 2 commits intoDockYard:masterfrom
Closed
add failing test for custom headers in multipart message#198romsahel wants to merge 2 commits intoDockYard:masterfrom
romsahel wants to merge 2 commits intoDockYard:masterfrom
Conversation
romsahel
commented
Apr 23, 2025
Comment on lines
+323
to
+352
| %Mail.Message{ | ||
| headers: %{ | ||
| "from" => "\"Sender\" <sender@example.com>", | ||
| "subject" => "Test Subject", | ||
| "to" => [{"", "recipient@example.com"}], | ||
| "x-custom-header-1" => "custom-header-value", | ||
| "x-custom-header-2" => "custom-header-value" | ||
| }, | ||
| body: nil, | ||
| parts: [ | ||
| %Mail.Message{ | ||
| headers: %{ | ||
| "content-transfer-encoding" => :quoted_printable, | ||
| "content-type" => ["text/plain", {"charset", "utf-8"}] | ||
| }, | ||
| body: "Test text body", | ||
| parts: [], | ||
| multipart: false | ||
| }, | ||
| %Mail.Message{ | ||
| headers: %{ | ||
| "content-transfer-encoding" => :quoted_printable, | ||
| "content-type" => ["text/html", {"charset", "UTF-8"}] | ||
| }, | ||
| body: "<html>html body</html>", | ||
| parts: [], | ||
| multipart: false | ||
| } | ||
| ], | ||
| multipart: true |
Contributor
Author
There was a problem hiding this comment.
We build the message using a combination of build_multipart |> put_from |> put_to |> put_header and using it in production, we had no issue before.
Collaborator
|
Sorry about the regression. I’ve pushed a fix to master. Please check that works for you. |
Contributor
Author
|
Excellent! Tested and it works for us, thanks a lot 🥇 |
Collaborator
|
I have released 0.5.1 with the regression fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Following this commit f738af7, we encounter an issue: when rendering a multi-part message, the headers are missing.
This PR adds 2 tests to showcase the problem:
mime-versionare present)I've attempted a fix in lib/mail/renderers/rfc_2822.ex although I'm unsure if it's the best way to approach the problem.