I ate your delicious whitespace!#39
Conversation
|
I made the CLI fail by removing whitespace. Amazing. CLI is so stable. |
|
Don't worry about CI there is a known random bug triggered in macos example. Will fix it soonish |
|
I think I found all the spaces for real this time. |
|
To make this truly useful maybe we should add an editor config or something that should make vscode obey the no trailing whitespaces and no tabs. |
|
I don't use VSCode but you could use something like a .editorconfig, yeah. |
|
I think this has potential for merge conflicts later on... I will let hang here until I merge major refactor of the reactor. Do not feel discouraged, you highlighted the problem that I need to fix anyway. |
|
Not a problem. I'll use the branch that doesn't have these changes for the iOS stuff then. |
|
I think it may be the time to return to this. Maybe even run formatter but I would want it to be customizable to maximally preserve the current style. Do you know if dfmt is capable of that? |
|
No I haven’t used dfmt, sorry. |
That's right, I found your trailing whitespace and I ate it all! >:)
I also converted some tab-spaces that I found into the ugly-spaces used throughout the rest of the project. (I love tab-spaces, so this is pure sacrilege to me.)
I also noticed that many lines in the Windows implementation are indented by 2 columns instead of 4? But I left that alone since… uh… it looked intentional?