Noindex generated classifier URLs and SSR classifier landing pages#9
Draft
DmitryMatv wants to merge 2 commits intomainfrom
Draft
Noindex generated classifier URLs and SSR classifier landing pages#9DmitryMatv wants to merge 2 commits intomainfrom
DmitryMatv wants to merge 2 commits intomainfrom
Conversation
- Add SEO routing logic to index only base classifier pages and noindex search/variant URLs - Server-render initial results on base landing pages with HTMX fallback and matching robots headers/meta - Update robots.txt and sitemap.xml to exclude fragment/query/generated search URLs - Source UNSPSC “current version” text from config and add regression tests for SEO behavior
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86b03f2e37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Disable server-side initial results rendering when any query params are present - Keep tracking/checkout-param landing URLs indexable with canonical base URL - Continue noindex behavior for `version`/`top_k` variant URLs - Add SEO tests for query-param GET/HEAD behavior and SSR skip checks
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index, follow) with canonical headers/meta.noindex, followviaX-Robots-Tagand page-level robots meta.app/web.py(canonical generation, query decoding, initial SSR fallback behavior).robots.txt, and remove generated search URLs fromsitemap.xml.Testing
tests/test_classifier_page_seo.pycovering base-page indexability, generated-page noindex behavior, canonical behavior, SSR fallback, and usage-tracking expectations.tests/test_homepage_headers.py,tests/test_request_validation_and_metadata.py) to verify robots directives and SSR-compatible page rendering.tests/test_static_headers.pyforrobots.txtdisallow rules and sitemap exclusions.top_kdefaults and reranking semantics.