Move first-party HX push URL decisions to client-side to protect cacheability#11
Open
DmitryMatv wants to merge 2 commits intomainfrom
Open
Move first-party HX push URL decisions to client-side to protect cacheability#11DmitryMatv wants to merge 2 commits intomainfrom
DmitryMatv wants to merge 2 commits intomainfrom
Conversation
- Keep fragment params canonical by removing `push_url` from loader/form payloads - Set `hx-push-url="false"` in template and compute clean first-party history targets in `classifier.ts` - Stop inferring history updates from `HX-Current-URL` server-side; honor explicit flags only - Expand TS/Python tests to lock in cache-safe history/title behavior
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56a2445f8c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- stop client-side slug/push-url prediction and navigate submits to `/{classifier}/search`
- add server-side query/version/top_k normalization plus canonical 301/303 redirects
- update TS/Python tests for NFC + whitespace normalization and canonical URL behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hx-push-urlupdates inclassifier.ts.push_urlfrom loader/form params and avoidingHX-Current-URL-driven server behavior.track_usage=trueto the classifier form and preserves history-disabled initial loader behavior.app/web.py(build_clean_classifier_url,resolve_push_url_enabled,resolve_page_title_enabled) and aligns title OOB behavior with explicit flags.AGENTS.mdto prevent regressions.Testing
app/assets/ts/classifier.test.tsfor canonical form params, loader params, and dynamichx-push-urlbehavior.tests/test_web_fragment_history.pyfor omitted/explicit push URL and title OOB behavior.tests/test_web_helpers.pyfor form/loader attributes and canonicalhx-vals.