Skip to content

Replace insecure MD5 hash with SHA-256 for PDF signature generation #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shivam-Singh-Dev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace insecure MD5 hash with SHA-256 for PDF signature generation #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/reportlab/pdfbase/pdfdoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from reportlab.lib.utils import import_zlib, open_for_read, makeFileName, isSeq, isBytes, isUnicode, _digester, isStr, bytestr, isPy3, annotateException
from reportlab.lib.rl_accel import escapePDF, fp_str, asciiBase85Encode, asciiBase85Decode
from reportlab.pdfbase import pdfmetrics
from hashlib import md5
from hashlib import md5,sha256

from sys import platform
from sys import version_info
Expand Down Expand Up @@ -146,7 +146,7 @@ def __init__(self,
self.setCompression(compression)
self._pdfVersion = pdfVersion
# signature for creating PDF ID
sig = self.signature = md5()
sig = self.signature = sha256()
sig.update(b"a reportlab document")
if not self.invariant:
cat = _getTimeStamp()
Expand Down