Skip to content

Conversation

@windymilla
Copy link
Collaborator

@windymilla windymilla commented Dec 23, 2025

If part of the caption already had <p class=..., an extra <p> was added before it, if the "Use <p>" checkbox is on.

Fixes #1633

If part of the caption already had `<p class=...`, an extra
`<p>` was added before it, if the "Use `<p>`" checkbox is on.
@windymilla windymilla requested a review from srjfoo December 23, 2025 12:48
@windymilla
Copy link
Collaborator Author

windymilla commented Dec 23, 2025

Testing notes:

  1. Starting with this pre-HTML-conversion file, note that part of the caption is marked up with /R.
  2. Run HTML conversion.
  3. Run Auto-illustration, ensuring Use <p> markup for caption checkbox is on.

In master, this results in <p><p class="right"> which is not legal.

Also try swapping the order of parts of the caption in the original and running the 3 steps above, so the right-aligned part is not the first part of the caption, etc.

@windymilla windymilla merged commit a8375ed into DistributedProofreaders:master Dec 27, 2025
1 check passed
@windymilla windymilla deleted the auto-illus-bug branch December 27, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double <p> markup in Auto-Illus

2 participants