Skip to content

Add missing JS files to eslint #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cpeel wants to merge 1 commit into from
Closed

Add missing JS files to eslint #1558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,33 @@ module.exports = [
"scripts/api.js",
"scripts/character_test.js",
"scripts/control_bar.js",
"scripts/dropdown.js",
Copy link
Copy Markdown
Collaborator

@chrismiceli chrismiceli Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why we didn't do *.js, because we should be able to, with appropriate excludes if necessary.

Copy link
Copy Markdown
Member Author

@cpeel cpeel Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't, this is me being dumb. We don't need this PR.

If I look closely this is the modules section which should only have the modules in it -- not the scripts which are covered under the wildcard above. And that's why the other changes were needed -- because they are being checked as modules even though they weren't.

Sorry for the kerfuffle and thanks for calling this out Chris.

"scripts/file_resume.js",
"scripts/filter_projects.js",
"scripts/gettext.js",
"scripts/navbar_menu.js",
"scripts/page_browse.js",
"scripts/page_table.js",
"scripts/project.js",
"scripts/splitControl.js",
"scripts/text_view.js",
"scripts/svgGraphs.js",
"scripts/tasks.js",
"scripts/text_validator.js",
"scripts/text_view.js",
"scripts/userprefs.js",
"scripts/view_splitter.js",
"scripts/word_freq_table.js",
"tools/page_browser.js",
"tools/project_manager/handle_bad_page.js",
"tools/project_manager/show_all_good_word_suggestions.js",
"tools/project_manager/show_word_context.js",
"tools/proofers/dp_proof.js",
"tools/proofers/dp_scroll.js",
"tools/proofers/previewControl.js",
"tools/proofers/proof_validate.js",
"tools/proofers/proof_image.js",
"tools/proofers/proof_validate.js",
"tools/proofers/srchrep.js",
"tools/proofers/toolbox.js",
"tools/proofers/wordcheck.js",
],
},
Expand Down
1 change: 1 addition & 0 deletions scripts/svgGraphs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* global d3 */
/* exported barLineGraph, stackedAreaGraph, pieGraph */

// eslint-disable-next-line no-unused-vars
const { barLineGraph, stackedAreaGraph, pieGraph } = (function () {
Copy link
Copy Markdown
Collaborator

@chrismiceli chrismiceli Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting the exported from above doesn't resolve this.

const margin = {
top: 30,
Expand Down
2 changes: 1 addition & 1 deletion tools/proofers/dp_proof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable no-use-before-define, no-undef, camelcase */
/* eslint-disable no-use-before-define, no-undef, camelcase, no-unused-vars */
/* exported insertCharacter, surroundSelection, changeFontFamily, changeFontSize, showNW, replaceAllText, transformText, submitForm */
// This variable is set by initializeStuff() in dp_scroll.js
var docRef = null;
Expand Down
2 changes: 1 addition & 1 deletion tools/proofers/dp_scroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable no-undef */
/* eslint-disable no-undef, no-unused-vars */
/* exported focusText, initializeStuff */
frameRef = null; // used by dp_proof.js

Expand Down
1 change: 1 addition & 0 deletions tools/proofers/srchrep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable no-unused-vars */
/* exported srchrep */

var srchrep = (function () {
Expand Down
2 changes: 1 addition & 1 deletion tools/proofers/toolbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/*global */
/* eslint-disable no-unused-vars */
Copy link
Copy Markdown
Collaborator

@chrismiceli chrismiceli Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I wonder if more exported are needed? Since we switched to modules though, we should rely on exports or window property assignments to resolve this?

/* exported openToolboxPopup */

var openedToolboxPopups = [];
Expand Down