Skip to content

Attempt to fix bug in dsm_var_prop #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VLucet wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Attempt to fix bug in dsm_var_prop #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2afac67
attempt to fix by trying to meet the requirements of the expected lis…
VLucet Mar 24, 2023
d10db89
Merge branch 'DistanceDevelopment:master' into val-fix-varprop
VLucet Mar 26, 2025
c3cf532
Update DESCRIPTION
VLucet Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ LazyLoad: yes
Authors@R:
c(person(given=c("David", "L."),
family="Miller",
role=c("aut")),
role=c("cre")),
person(given="Eric",
family="Rexstad",
role="ctb"),
Expand Down
12 changes: 10 additions & 2 deletions R/varprop_check.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@ varprop_check <- function(object){

# make a skeleton for the detection function parameters over all models
parskel <- list()
for(i in seq_along(object$old_model$ddf)){
parskel[[i]] <- object$old_model$ddf[[i]]$par
if(class(object) == "list") {
for(i in seq_along(object$old_model$ddf)){
parskel[[i]] <- object$old_model$ddf[[i]]$par
}
} else if(class(object) == "dsm_varprop"){
parskel[[1]] <- object$old_model$ddf$par
}

# which parameters in the GAM are only in the refit?
Expand All @@ -19,6 +23,10 @@ varprop_check <- function(object){
ddf_corrections <- relist(extra_gam_pars, parskel)

vp_diag <- list()

if(class(object) == "dsm_varprop") {
object$old_model$ddf <- list(object$old_model$ddf)
}

for(ii in seq_along(object$old_model$ddf)){
# get the data in order
Expand Down