Skip to content

Conversation

@LHMarshall
Copy link
Member

@lenthomas can you please check the re-worded documentation and let me know if you spot anything that I missed. There are also more documentation changes in mrds and I'll create a new pull request there too. Thanks, Laura

@LHMarshall LHMarshall requested a review from lenthomas April 3, 2025 11:37
@lenthomas
Copy link
Member

Looks good. A few things:

  • I spotted a few more places where examples.distancesampling.org should be changed to distancesampling.org/resources/vignettes.html I suggest doing a global search in all of the .R files for this.
  • I think changed the reference to Innes et al. on line 117 to \insertCite{innes2002;textual}{mrds} -- this is how it's cited in dht2.R and it seems to work -- but I don't understand how because I do not see a REFERENCES.bib file in the inst directory of the mrds package. ( I got my knowledge on how to do this from this help file so I may mis-understand something.)
  • I edited just the .R files, not the .Rd ones
  • I guess there will need to be some changes to documentation in the mrds package also.

@erex
Copy link
Member

erex commented Apr 19, 2025

I made a list of .R files referencing our out-of-date examples.distancesampling.org in the agenda of our January DistDev meeting under Other
https://github.com/DistanceDevelopment/distance-dev/wiki/Distance-development-meeting-22-January-2025#other

I count 13 files that need to be updated to point to useful vignettes.

@LHMarshall LHMarshall merged commit f53ef71 into master Apr 29, 2025
0 of 4 checks passed
@LHMarshall LHMarshall deleted the Issue-192 branch April 29, 2025 12:04
@LHMarshall
Copy link
Member Author

Closes #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants