Add not statements for event mail creator, and fix event_email to event_mail#683
Open
koenjdejong wants to merge 1 commit into
Open
Add not statements for event mail creator, and fix event_email to event_mail#683koenjdejong wants to merge 1 commit into
koenjdejong wants to merge 1 commit into
Conversation
dexbleeker
approved these changes
May 5, 2026
|
|
||
| def send_new_event_email | ||
| # Send new event to all leden who have new_event_email enabled | ||
| def send_new_event_mail |
Member
There was a problem hiding this comment.
Gaat deze rename goed? Waar callen we hem?
Collaborator
There was a problem hiding this comment.
Nee, gaat niet goed.
jackozi
reviewed
May 5, 2026
| if self.usergroup_id.nil? | ||
| unless self.attendance # If not dispuutsborrel | ||
| User.intern.where(new_event_mail: true).each { |user| UserMailer.mail_new_event(user, self).deliver } | ||
| User.intern.where(new_event_mail: true).where.not(id: self.user_id).each { |user| UserMailer.mail_new_event(user, self).deliver } |
Collaborator
There was a problem hiding this comment.
Suggested change
| User.intern.where(new_event_mail: true).where.not(id: self.user_id).each { |user| UserMailer.mail_new_event(user, self).deliver } | |
| User.intern.where(new_event_mail: true).excluding(user).each { |user| UserMailer.mail_new_event(user, self).deliver } |
zou volgens mij ook moeten werken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #546
Used from: #681