docs(collections): clarify that store method bounds are per-method#639
Merged
ealmloff merged 1 commit intoDioxusLabs:mainfrom Mar 18, 2026
Conversation
The documentation for 'Extending stores with methods' was ambiguous about whether the Lens bounds are generated per-function or for the whole impl block. This change clarifies that bounds are added on a per-method basis, allowing different methods to have different Lens bounds within the same impl block. Fixes DioxusLabs/dioxus#5380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies the documentation for 'Extending stores with methods' to explicitly state that Lens bounds are added on a per-method basis, not for the entire impl block.
The original text was ambiguous about whether bounds are generated per-function or shared across the whole impl block. This change makes it clear that:
\&selfrequireReadable\&mut selfrequireWritableselfby value have no boundsFixes DioxusLabs/dioxus#5380