fix(router): decode '+' as space in URL query strings#5388
Open
mango766 wants to merge 1 commit intoDioxusLabs:mainfrom
Open
fix(router): decode '+' as space in URL query strings#5388mango766 wants to merge 1 commit intoDioxusLabs:mainfrom
mango766 wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
Per the application/x-www-form-urlencoded spec, '+' is a valid encoding for space in query strings. Some services (e.g. Facebook Messenger) rewrite '%20' to '+' when processing URLs, which caused the router to pass through the literal '+' character instead of decoding it as a space. This replaces '+' with space before percent-decoding the query string, matching the behavior expected by the URL spec. Fixes DioxusLabs#5280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5280
The Dioxus router currently uses
percent_decode_strto decode query strings, but this only handles%XX-style percent encoding. Per the application/x-www-form-urlencoded spec,+is a valid encoding for space in query strings. Some services (e.g. Facebook Messenger) rewrite%20to+when processing URLs, causing the router to pass through the literal+character.This PR replaces
+with space in the query string before percent-decoding, matching the expected URL behavior.Changes
packages/router-macro/src/lib.rs: In the generatedFromStrimplementation, replace+with space in the query string before callingpercent_decode_strpackages/router/tests/parsing.rs: Addedquery_plus_decoded_as_spacetest verifying+is decoded as space,%20still works, and multiple+signs are handledExample