fix(cli): skip platform-specific test assertions when tools are unavailable#5386
Open
Dieshen wants to merge 1 commit intoDioxusLabs:mainfrom
Open
fix(cli): skip platform-specific test assertions when tools are unavailable#5386Dieshen wants to merge 1 commit intoDioxusLabs:mainfrom
Dieshen wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
…ilable The test_harnesses::run_harness test panics on machines without Android NDK/SDK installed and on non-macOS platforms for iOS assertions. Skip these assertions gracefully instead of failing the entire test suite. - Android assertions: skip when get_android_tools() returns None - iOS assertions: skip when not running on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_android_tools()returnsNone)cfg!(not(target_os = "macos")))Problem
test_harnesses::run_harnesspanics withFailed to get android toolson machines without the Android NDK/SDK installed. The same test also fails on non-macOS platforms for iOS assertions. This blocks contributors from runningcargo test --workspacesuccessfully.Test plan
cargo test -p dioxus-cli --bin dx -- test_harnesses::run_harnesspasses on Windows without Android NDK