chore: add .gitattributes for consistent line endings#5385
Open
Dieshen wants to merge 1 commit intoDioxusLabs:mainfrom
Open
chore: add .gitattributes for consistent line endings#5385Dieshen wants to merge 1 commit intoDioxusLabs:mainfrom
Dieshen wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
Normalize line endings to LF across all platforms. Without this, Windows contributors get CRLF warnings on every checkout and test run due to generated harness files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitattributesto normalize line endings to LF across all platformsProblem
Windows contributors currently get CRLF warnings on checkout and after running tests (especially from generated
cli-harnessesfiles). This is noisy and can lead to accidental line ending changes in PRs.Test plan