fix: Content-hash-based filename when bundling with wasm_split#5340
Open
SuperKenVery wants to merge 1 commit intoDioxusLabs:mainfrom
Open
fix: Content-hash-based filename when bundling with wasm_split#5340SuperKenVery wants to merge 1 commit intoDioxusLabs:mainfrom
SuperKenVery wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
|
could you please add an explanation to the body of the commit message why this is done? My assumption is that it helps with caching? |
Author
|
Yes exactly, this fixes caching. Without this, clients will use old html or wasm files even if server has updated. I added description to PR body. Adding to commit body would require force push, tell me if you want that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add content hash to asset filenames. Without this, client may continue to use cached old versions even if the server has been updated.
I tried directly removing the
self.wasm_splitcheck. Seems working well.Closes #5339