fix(cli): replace panicking unwrap/index with proper error propagation in linker#5329
Open
junovhs wants to merge 1 commit intoDioxusLabs:mainfrom
Open
fix(cli): replace panicking unwrap/index with proper error propagation in linker#5329junovhs wants to merge 1 commit intoDioxusLabs:mainfrom
junovhs wants to merge 1 commit intoDioxusLabs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_link_innercould have a panic in two ways when fixing the output path -.unwrap()on.position()when searching for-oin linker args, it panics if-ois absentargs[out + 1], it panics if-ois the last argument with nothing after it.unwrap()on.find()for/OUT:on Windows. same issue.I also was inclined to replace
.expect("Failed to run linker")oncmd.output()with.context(...)?so that the linker spawn failures propagate clean.extracted the output path resolution into
resolve_output_pathfor clarity. Errors now propagate viaanyhow::Contextinstead of paniking.