feat: windows app icon

_typos.toml

@@ -14,4 +14,4 @@ unparented = "unparented"
 flate2="flate2"
 
 [files]
-extend-exclude = ["notes/translations/*", "CHANGELOG.md", "*.js"]
+extend-exclude = ["notes/translations/*", "CHANGELOG.md", "*.js", "packages/cli/src/build/windows.rs"]

packages/cli/schema.json

@@ -541,6 +541,13 @@
             "null"
           ]
         },
+        "name": {
+          "description": "Display name of the application",
+          "type": [
+            "string",
+            "null"
+          ]
+        },
         "out_dir": {
           "type": [
             "string",
@@ -649,6 +656,12 @@
             "type": "string"
           }
         },
+        "file_version": {
+          "type": [
+            "string",
+            "null"
+          ]
+        },
         "icon": {
           "type": [
             "array",
@@ -680,6 +693,12 @@
             }
           ]
         },
+        "original_file_name": {
+          "type": [
+            "string",
+            "null"
+          ]
+        },
         "publisher": {
           "type": [
             "string",
@@ -701,6 +720,18 @@
             "null"
           ]
         },
+        "trademark": {
+          "type": [
+            "string",
+            "null"
+          ]
+        },
+        "version": {
+          "type": [
+            "string",
+            "null"
+          ]
+        },
         "windows": {
           "anyOf": [
             {

packages/cli/src/build/mod.rs

@@ -12,6 +12,7 @@
 mod android;
 mod apple;
 mod web;
+mod windows;
 
 mod assets;
 mod builder;

packages/cli/src/build/request.rs

@@ -1767,6 +1767,16 @@ impl BuildRequest {
                 cargo_args.push("-Clink-arg=-Wl,-rpath,$ORIGIN/../lib".to_string());
                 cargo_args.push("-Clink-arg=-Wl,-rpath,$ORIGIN".to_string());
             }
+            OperatingSystem::Windows => match self.write_winres() {
+                Ok(res) => {
+                    cargo_args.extend(["-L".to_string(), res.path, "-l".to_string(), res.lib]);
+                }
+                Err(err) => {
+                    if self.using_dioxus_explicitly {
+                        tracing::warn!("Application may not have an icon: {err}");
+                    }
+                }
+            },
             _ => {}
         }
 
@@ -2505,7 +2515,7 @@ impl BuildRequest {
     /// target/dx/build/app/web/
     /// target/dx/build/app/web/public/
     /// target/dx/build/app/web/server.exe
-    fn platform_dir(&self) -> PathBuf {
+    pub(crate) fn platform_dir(&self) -> PathBuf {
         self.internal_out_dir()
             .join(&self.main_target)
             .join(if self.release { "release" } else { "debug" })