Skip to content

fix(api): re-raise RateLimitError after exhausting retries #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guanbinrui wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(api): re-raise RateLimitError after exhausting retries #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/apiutils.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,13 +178,19 @@ template fetchImpl(result, fetchBody) {.dirty.} =
release(session)

template retry(bod) =
for i in 0 ..< maxRetries:
let attempts = max(maxRetries, 1)
for i in 0 ..< attempts:
try:
bod
break
except RateLimitError:
echo "[sessions] Rate limited, retrying ", req.cookie.endpoint,
" request (", i, "/", maxRetries, ")..."
" request (", i + 1, "/", attempts, ")..."
# Re-raise on the final attempt so the error propagates to Jester's
# RateLimitError handler. Swallowing it would let fetch/fetchRaw return
# a nil JsonNode, which the parsers dereference -> SIGSEGV in -d:danger.
if i == attempts - 1:
raise
if retryDelayMs > 0:
await sleepAsync(retryDelayMs)

Expand Down