Skip to content

fix: mf-6769 keep timeline post stable on show more expand #12400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swkatmask wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −1
Open

fix: mf-6769 keep timeline post stable on show more expand #12400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/mask/content-script/site-adaptors/twitter.com/collecting/post.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,11 @@ function registerPostCollectorInner(
// To distinguish tweet nodes between timeline and detail page
const isDetailPage = isDetailTweet(tweetNode)
const isCollapsed = !!tweetNode.querySelector('[data-testid="tweet-text-show-more-link"]')
return `${isDetailPage ? 'detail' : 'normal'}/${parentTweetId}/${tweetId}/collapse:${isCollapsed}`
// Keep the collapse suffix only on the detail page (MF-5908): changing the key forces
// Mask content to re-inject when a collapsed tweet expands there. On the timeline the key
// change unmounts+remounts the whole post card on expand (flicker), so the post stays stable
// and onNodeMutation updates its content in place (MF-6769).
return `${isDetailPage ? 'detail' : 'normal'}/${parentTweetId}/${tweetId}${isDetailPage ? `/collapse:${isCollapsed}` : ''}`
})
.startWatch(250, cancel)
}
Expand Down
Loading