version 1.6.0-beta01#2208
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 946050b406
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: Publish to Google Play | ||
| if: startsWith(github.ref, 'refs/tags/') | ||
| # if: startsWith(github.ref, 'refs/tags/') |
There was a problem hiding this comment.
Because this workflow also runs for pushes to master/release/develop and for pull requests, commenting out this if makes the Google Play upload step run after every Android CI build instead of only tag builds. In PRs where SERVICE_ACCOUNT_JSON is unavailable this will fail the job, and on branch pushes with secrets it can upload non-tagged run-number builds to the internal Play track.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: acab4fd723
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .toolbar { | ||
| ToolbarItem(placement: .primaryAction) { | ||
| Button(action: onNewConversation) { | ||
| NavigationLink(value: Route.agentChat(Route.newGenericChatConversationId(), nil)) { |
There was a problem hiding this comment.
Because this NavigationLink value is constructed while SwiftUI renders the toolbar, not when the user taps the plus button, the timestamp-based generic-chat: id can be stale when the user returns from a newly created chat and taps plus again. In that case the app can navigate back to the same conversation id instead of creating a fresh conversation; the previous button action generated Route.newGenericChatConversationId() at tap time.
Useful? React with 👍 / 👎.
1 participant
No description provided.