Improving functions and adding other needed element#1
Open
DimaTomilin wants to merge 18 commits intomainfrom
Open
Improving functions and adding other needed element#1DimaTomilin wants to merge 18 commits intomainfrom
DimaTomilin wants to merge 18 commits intomainfrom
Conversation
Adding all of necessary functions and checking of their work in the browser
Making code more readable and effective. Improving function of CreateElement and making player
Adding styles in CSS working with elements classes and id
New requirements to work branch
…into Work-of-Dima
Adding bonus task that duration of the song has different colors that depends of durations(less than 2 minute or more than 7)
I copied all functions from index.js that I used before to new javascript file Making all css file in comment because it is useless at the moment
Adding event playsong that make other background to song that playing in the moment
Adding function RemoveSong that can remove song from player and also from playlists after that it reload all DOM elements Also making event Delegation to play-song button and remove-song button
Making Add button and all inputs worked Improved playSong functions addSongFunction add song to the player and add it to the DOM elements
CSS to my file
…into Work-of-Dima
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding all of necessary functions and checking of their work in the browser