Feature/remove hardcoded data properties#20
Open
rrfenton wants to merge 2 commits intoDigiExam:masterfrom
Open
Feature/remove hardcoded data properties#20rrfenton wants to merge 2 commits intoDigiExam:masterfrom
rrfenton wants to merge 2 commits intoDigiExam:masterfrom
Conversation
added 2 commits
April 8, 2016 16:33
…hecks if there is any properties on the object
…hecks if there is any properties on the object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seemed weird that the logic for if the tooltip popped up required either data.comment or data.points, especially since it seems like data is just a blob to stick data that is on the annotation. I replaced the check of those properties to instead be a check if the data object has any properties.
Also lol updating a 2 year old library.