fix(frontend): intercept ws connection in tests #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesDoingStuff
requested review from
TBThomas56,
VictoriaBeilsten-Edmands,
davehadley and
teoching0705
davehadley
approved these changes
Jan 22, 2026
| ), | ||
|
|
||
| // Catch all remaining unintercepted queries | ||
| api.operation(() => {}), |
Collaborator
There was a problem hiding this comment.
Does handler ordering matter for Mock Service Worker? eg does the "catch all" handler have to go last?
Contributor
Author
There was a problem hiding this comment.
I had thought so - MSW iterates through the handlers in order, using the first one that handles the request - but I've just seen that returning nothing doesn't actually count as handling, so I suppose it doesn't matter. I think this will still suffice for intercepting though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a handler for a protocol upgrade request that was seen to be uncaught when running
TemplateView.test.tsx(specifically, the test that 'submits' a workflow).Also adds another GraphQL handler that will match and block any request that hasn't already matched one of the previous predicates.