Skip to content

Updated jungfrau rotation devices#1721

Merged
olliesilvester merged 16 commits intomainfrom
updated-jungfrau-rotation-devices
Jan 14, 2026
Merged

Updated jungfrau rotation devices#1721
olliesilvester merged 16 commits intomainfrom
updated-jungfrau-rotation-devices

Conversation

@olliesilvester
Copy link
Copy Markdown
Contributor

@olliesilvester olliesilvester commented Nov 19, 2025

Supersedes #1473

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram
Copy link
Copy Markdown
Contributor

May supersede #1473, @olliesilvester to get these into one PR and if it's a simple one let's just get them merged

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.14%. Comparing base (d531193) to head (74fd10c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1721   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         288      288           
  Lines       10943    10952    +9     
=======================================
+ Hits        10849    10858    +9     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olliesilvester olliesilvester marked this pull request as ready for review December 19, 2025 14:14
@olliesilvester olliesilvester requested a review from a team as a code owner December 19, 2025 14:14
@rtuck99 rtuck99 self-assigned this Jan 12, 2026
AutoIncrementingPathProvider(
StaticFilenameProvider(filename), PurePath(path_to_dir)
),
AutoMaxIncrementingPathProvider(get_path_provider()),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be anything that calls set_path_provider()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@olliesilvester olliesilvester merged commit 0d4f838 into main Jan 14, 2026
19 of 20 checks passed
@olliesilvester olliesilvester deleted the updated-jungfrau-rotation-devices branch January 14, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants