Updated jungfrau rotation devices#1721
Merged
olliesilvester merged 16 commits intomainfrom Jan 14, 2026
Merged
Conversation
Contributor
|
May supersede #1473, @olliesilvester to get these into one PR and if it's a simple one let's just get them merged |
This was referenced Dec 5, 2025
Closed
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1721 +/- ##
=======================================
Coverage 99.14% 99.14%
=======================================
Files 288 288
Lines 10943 10952 +9
=======================================
+ Hits 10849 10858 +9
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtuck99
reviewed
Jan 12, 2026
| AutoIncrementingPathProvider( | ||
| StaticFilenameProvider(filename), PurePath(path_to_dir) | ||
| ), | ||
| AutoMaxIncrementingPathProvider(get_path_provider()), |
Contributor
There was a problem hiding this comment.
There doesn't seem to be anything that calls set_path_provider()
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1473
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}