Skip to content

LIMS-2109: Require an email address when creating a plate#1037

Open
ndg63276 wants to merge 2 commits intomasterfrom
improvement/LIMS-2109/require-email-address-when-creating-plates
Open

LIMS-2109: Require an email address when creating a plate#1037
ndg63276 wants to merge 2 commits intomasterfrom
improvement/LIMS-2109/require-email-address-when-creating-plates

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-2109

Summary:

If a plate is created and the owner does not have an email address in ISPyB, then errors occur on the beamline. We should make email address required for plate owners.

Changes:

  • Fail validation if the container type is a plate and the owner has no email address
  • Hide the default error message and show custom ones instead
  • Remove the tw-items-center class so all the items in the row are aligned vertically

To test:

  • Go to an proposal mx23694
  • Go to any shipment and click "Add Container"
  • Keep the container type as Puck, and choose Sue Pulford-Fletcher as the Owner. Check an advisory message appears to encourage filling in the email address, but that you can create the puck regardless
  • On a new container, change the container type to a plate (eg CrystalQuickX), and choose Sue as the owner again. Check the box turns red and you are not allowed to create the container
  • Change the owner to someone with an email address, check you can now create the container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant