Update audit.py by DiabeticTurtle · Pull Request #1 · DiabeticTurtle/DiamodPlugins

DiabeticTurtle · 2021-07-13T20:59:57Z

No description provided.

code-review-doctor

Some food for thought. View full project report here.

code-review-doctor

Worth considering. View full project report here.

code-review-doctor · 2022-09-20T18:31:55Z

moderation/moderation.py

+
+info_json = Path(__file__).parent.resolve() / "info.json"
+with open(info_json, encoding="utf-8") as f:
+    __plugin_info__ = json.loads(f.read())


Suggested change

__plugin_info__ = json.loads(f.read())

__plugin_info__ = json.load(f)

This can be simplified by using json.load(...). Read more.

code-review-doctor · 2022-09-20T18:31:55Z

moderation/moderation.py

+            try:
+                user = await self.bot.get_or_fetch_user(user_id)
+            except (discord.NotFound, Exception):
+                raise commands.BadArgument('"{}" not found. Invalid user ID.'.format(user_id))


f-string is easier to read, write, and less computationally expensive than legacy string formatting. More.

code-review-doctor · 2022-09-20T18:31:55Z

moderation/moderation.py

+        except Exception as exc:
+            err = f"{type(exc).__name__}: {str(exc)}"
+            raise commands.BadArgument(
+                "Error renaming {name}#{discrim}.\n```Haskell\n{error}\n```".format(


Likewise, Consider using f-string instead.

code-review-doctor

Worth considering. View full project report here.

code-review-doctor · 2022-10-10T07:50:04Z

tags/models.py

+from discord.ext import commands
+
+
+class SafeFormat(object):


Suggested change

class SafeFormat(object):

class SafeFormat:

SafeFormat inherits from object by default, so explicitly inheriting from object is redundant. Removing it keeps the code simpler. Read more.

code-review-doctor · 2022-10-10T07:50:04Z

tags/models.py

+        self.__dict = kw
+
+    def __getitem__(self, name):
+        return self.__dict.get(name, SafeString('{%s}' % name))


Suggested change

return self.__dict.get(name, SafeString('{%s}' % name))

return self.__dict.get(name, SafeString(f'{{{name}}}'))

f-string is easier to read, write, and less computationally expensive than legacy string formatting. Explained here.

code-review-doctor · 2022-10-10T07:50:04Z

tags/models.py

+        try:
+            super().__getattr__(name)
+        except AttributeError:
+            return SafeString('%s.%s}' % (self[:-1], name))


Suggested change

return SafeString('%s.%s}' % (self[:-1], name))

return SafeString(f'{self[:-1]}.{name}}}')

Similarly, Consider using f-string instead.

code-review-doctor

Some things to consider. View full project report here.

code-review-doctor · 2022-10-10T10:07:51Z

moderation/moderation.py

+    async def on_guild_channel_create(self, channel):
+        """Sets up mute role permissions for the channel."""
+        muterole = await self.db.find_one({"_id": "muterole"})
+        if muterole == None:


Suggested change

if muterole == None:

if muterole is None:

None is a singleton data type, so should be compared using is. More.

code-review-doctor · 2022-10-10T10:07:51Z

moderation/moderation.py

+            return
+
+        role = channel.guild.get_role(muterole[str(channel.guild.id)])
+        if role == None:


Suggested change

if role == None:

if role is None:

Again, Use is.

code-review-doctor · 2022-10-10T10:07:52Z

moderation/moderation.py

+    @checks.has_permissions(PermissionLevel.MODERATOR)
+    async def setlog(self, ctx, channel: discord.TextChannel = None):
+        """Sets up a log channel."""
+        if channel == None:


Suggested change

if channel == None:

if channel is None:

Similarly, Use is.

code-review-doctor · 2022-10-10T10:07:52Z

moderation/moderation.py

+                    ctx.guild.get_role(
+                        (await self.db.find_one({"_id": "muterole"}))[str(ctx.guild.id)]
+                    )
+                    != None


Suggested change

!= None

is not None

Same as above: Use is not.

code-review-doctor · 2022-10-10T10:07:52Z

moderation/moderation.py

+        """
+        Warns the specified member.
+        """
+        if member == None:


Suggested change

if member == None:

if member is None:

Same as above: Use is.

code-review-doctor · 2022-10-10T10:07:54Z

moderation/moderation.py

+            return await ctx.send_help(ctx.command)
+        role = await self.db.find_one({"_id": "muterole"})
+        no_role = False
+        if role == None:


Suggested change

if role == None:

if role is None:

Similarly, Use is.

code-review-doctor · 2022-10-10T10:07:54Z

moderation/moderation.py

+            no_role = True
+        elif str(ctx.guild.id) in role:
+            role = ctx.guild.get_role(role[str(ctx.guild.id)])
+            if role == None:


Suggested change

if role == None:

if role is None:

Likewise, Use is.

code-review-doctor · 2022-10-10T10:07:55Z

moderation/moderation.py

+            if role == None:
+                no_role = True
+
+        if reason != None:


Suggested change

if reason != None:

if reason is not None:

Likewise, Use is not.

code-review-doctor · 2022-10-10T10:07:55Z

moderation/moderation.py

+                    title="Error",
+                    description=(
+                        "You don't have a muted role set up.\n"
+                        f"You will have to unmute them manually."


Suggested change

f"You will have to unmute them manually."

"You will have to unmute them manually."

f-string is unnecessary here. This can just be a string. More details.

code-review-doctor · 2022-10-10T10:07:55Z

moderation/moderation.py

+        Nukes (deletes EVERY message in) a channel.
+        You can mention a channel to nuke that one instead.
+        """
+        if channel == None:


Suggested change

if channel == None:

if channel is None:

Similarly, Use is.

code-review-doctor

Some food for thought. View full project report here.

code-review-doctor · 2022-10-10T10:08:00Z

moderation/moderation.py

+            return await ctx.send(
+                embed=discord.Embed(
+                    title="Error",
+                    description=f"You can only purge up to 2000 messages.",


Suggested change

description=f"You can only purge up to 2000 messages.",

description="You can only purge up to 2000 messages.",

As above, f-string is unnecessary here.

code-review-doctor · 2022-10-10T10:08:00Z

moderation/moderation.py

+    async def get_case(self):
+        """Gives the case number."""
+        num = await self.db.find_one({"_id": "cases"})
+        if num == None:


Suggested change

if num == None:

if num is None:

As above, Use is.

code-review-doctor · 2022-10-10T10:08:00Z

moderation/moderation.py

+    async def log(self, guild: discord.Guild, embed: discord.Embed):
+        """Sends logs to the log channel."""
+        channel = await self.db.find_one({"_id": "logging"})
+        if channel == None:


Suggested change

if channel == None:

if channel is None:

As above, Use is.

code-review-doctor · 2022-10-10T10:08:00Z

moderation/moderation.py

+        if not str(guild.id) in channel:
+            return
+        channel = self.bot.get_channel(channel[str(guild.id)])
+        if channel == None:


Suggested change

if channel == None:

if channel is None:

Likewise, Use is.

code-review-doctor

Worth considering. View full project report here.

DiabeticTurtle added 3 commits July 13, 2021 16:29

Update audit.py

5fc7455

Create rolemanager.py

72b90fd

test tags

ef4aa87

code-review-doctor bot suggested changes Sep 20, 2022

View reviewed changes

Repository owner deleted a comment from code-review-doctor bot Sep 20, 2022

DiabeticTurtle added 2 commits September 20, 2022 14:20

test tags

d71c624

Create moderation.py

d601a87

code-review-doctor bot suggested changes Sep 20, 2022

View reviewed changes

add some stuff ig

cad4f92

code-review-doctor bot suggested changes Oct 10, 2022

View reviewed changes

DiabeticTurtle added 3 commits October 10, 2022 05:45

Update moderation.py

b178a3a

Update moderation.py

9f0d109

Update moderation.py

84bac01

code-review-doctor bot suggested changes Oct 10, 2022

View reviewed changes

DiabeticTurtle added 9 commits December 6, 2022 17:44

Update tags.py

583350e

add embed

1db2c7d

add category support

9bb30de

testing slash commands

94bcbfa

edit file typo

142e2b2

Update slashcmd.py

ff35e42

Update tags.py

0cd22b9

Update tags.py

9b0bb6e

add embed support to categories

fa26106

code-review-doctor bot suggested changes Dec 7, 2022

View reviewed changes

Repository owner deleted a comment from code-review-doctor bot Dec 7, 2022

DiabeticTurtle added 2 commits December 6, 2022 20:04

Update tags.py

eb525d5

Update tags.py

9f615b8

DiabeticTurtle added 10 commits December 6, 2022 20:30

Update tags.py

0969533

Update tags.py

725f06b

Create rolereact

97f7759

no summary

6bc6073

Update reactionrole

ae3fb3b

Update reactionrole

a584d28

Create reactionrole.py

1e418c1

Update reactionrole.py

a98c184

Delete reactionrole

34fc933

Update reactionrole.py

26014f5

	__plugin_info__ = json.loads(f.read())
	__plugin_info__ = json.load(f)

	return self.__dict.get(name, SafeString('{%s}' % name))
	return self.__dict.get(name, SafeString(f'{{{name}}}'))

	return SafeString('%s.%s}' % (self[:-1], name))
	return SafeString(f'{self[:-1]}.{name}}}')

	f"You will have to unmute them manually."
	"You will have to unmute them manually."

	description=f"You can only purge up to 2000 messages.",
	description="You can only purge up to 2000 messages.",

Comments

Conversation

DiabeticTurtle commented Jul 13, 2021

Uh oh!

code-review-doctor bot left a comment

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot left a comment

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Sep 20, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Sep 20, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Sep 20, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot left a comment

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot left a comment

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot left a comment

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

code-review-doctor bot left a comment