Repository navigation
Preserve Windows direct connections and stabilize template tests - #564
Merged
Merged
Conversation
zjy-web222
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve an explicit
NO_PROXY=*when the Windows desktop starts child processes. This keeps the desktop from reintroducing the system proxy after a user opts into direct connections.Normalize checkout line endings in the existing bundled-template test and close template stores before removing test directories.
Validation
node --test apps/desktop/electron/runtime.test.mjspassed all 24 tests.apps/server,bun test --isolate --timeout 60000 src/templates.test.ts --test-name-pattern 'video motion map|build copies'passed both tests against the local catalog.EPERM; a standalone symlink call reproduced the host restriction.NO_PROXY=*without injected proxy variables.