🎨 Palette: Enhance Modal accessibility and keyboard support #216
Conversation
- Added `useEffect` to handle Escape key for closing the modal. - Added `role="dialog"` and `aria-modal="true"` to the modal container. - Linked modal title with `aria-labelledby` using `useId`. - Added `aria-label` to the close button. - Prevented body scrolling when modal is open. - Created `.Jules/palette.md` to track UX learnings.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
✅ Deploy Preview for split-but-wiser ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 74.42% 74.42%
=======================================
Files 17 17
Lines 1693 1693
Branches 158 158
=======================================
Hits 1260 1260
Misses 381 381
Partials 52 52
🚀 New features to boost your workflow:
|
This PR addresses critical accessibility gaps in the
Modalcomponent. It adds standard ARIA attributes (role="dialog",aria-modal,aria-labelledby) and keyboard support (closing on Escape key), improving the experience for screen reader users and keyboard navigators. It also locks body scroll when the modal is open.PR created automatically by Jules for task 7117747166083028368 started by @Devasy23