Skip to content

Refactor backend services to reduce technical debt #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
google-labs-jules wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Refactor backend services to reduce technical debt #151

google-labs-jules wants to merge 15 commits into from

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Aug 16, 2025

This pull request addresses several areas of technical debt in the backend, making the codebase more maintainable, scalable, and secure. The key changes include:

  • Dependency Management: Development and production dependencies have been separated into requirements-dev.txt and requirements.txt respectively.
  • Configuration: The application configuration has been refactored to remove insecure defaults and simplify settings for CORS and Firebase.
  • Service Layer: A BaseService has been introduced to abstract common database operations. All services (UserService, ExpenseService, GroupService, AuthService) have been refactored to use this base service and FastAPI's dependency injection, removing singleton patterns and direct database access.
  • API Routers: All API routers have been updated to use the refactored, injectable services.

These changes improve the overall architecture of the backend, reduce code duplication, and make the application easier to test and maintain.

google-labs-jules bot and others added 2 commits August 16, 2025 04:25
@google-labs-jules
Refactor backend services to reduce technical debt
37688cb 
This commit addresses several areas of technical debt in the backend:

- Separated development and production dependencies into `requirements.txt` and `requirements-dev.txt`.
- Refactored the configuration in `app/config.py` to improve security and clarity.
- Simplified the CORS configuration in `main.py`.
- Introduced a `BaseService` class to handle common CRUD operations and reduce code duplication.
- Refactored `UserService`, `ExpenseService`, `GroupService`, and `AuthService` to use the `BaseService` and dependency injection.
- Updated all API routers to use dependency injection for the services.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d808eca 
for more information, see https://pre-commit.ci
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 16, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Devasy23 Devasy23 marked this pull request as ready for review August 16, 2025 04:27
@Devasy23 Devasy23 self-requested a review as a code owner August 16, 2025 04:27
google-labs-jules bot and others added 13 commits August 16, 2025 04:35
@google-labs-jules
Refactor backend services to reduce technical debt
ead76cc 
This commit addresses several areas of technical debt in the backend:

- Separated development and production dependencies into `requirements.txt` and `requirements-dev.txt`.
- Refactored the configuration in `app/config.py` to improve security and clarity.
- Simplified the CORS configuration in `main.py`.
- Introduced a `BaseService` class to handle common CRUD operations and reduce code duplication.
- Refactored `UserService`, `ExpenseService`, `GroupService`, and `AuthService` to use the `BaseService` and dependency injection.
- Updated all API routers to use dependency injection for the services.
- Updated the CI workflow to install development dependencies.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f575d77 
for more information, see https://pre-commit.ci
@google-labs-jules
Refactor backend services to reduce technical debt
01ba53f 
This commit addresses several areas of technical debt in the backend:

- Separated development and production dependencies into `requirements.txt` and `requirements-dev.txt`.
- Refactored the configuration in `app/config.py` to improve security and clarity.
- Simplified the CORS configuration in `main.py`.
- Introduced a `BaseService` class to handle common CRUD operations and reduce code duplication.
- Refactored `UserService`, `ExpenseService`, `GroupService`, and `AuthService` to use the `BaseService` and dependency injection.
- Updated all API routers to use dependency injection for the services.
- Updated the CI workflow to install development dependencies.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
15cf5be 
for more information, see https://pre-commit.ci
@google-labs-jules
Refactor backend services to reduce technical debt
f02416f 
This commit addresses several areas of technical debt in the backend:

- Separated development and production dependencies into `requirements.txt` and `requirements-dev.txt`.
- Refactored the configuration in `app/config.py` to improve security and clarity.
- Simplified the CORS configuration in `main.py`.
- Introduced a `BaseService` class to handle common CRUD operations and reduce code duplication.
- Refactored `UserService`, `ExpenseService`, `GroupService`, and `AuthService` to use the `BaseService` and dependency injection.
- Updated all API routers to use dependency injection for the services.
- Updated the CI workflow to install development dependencies.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d916928 
for more information, see https://pre-commit.ci
@google-labs-jules
Refactor backend services to reduce technical debt
26f74ec 
This commit addresses several areas of technical debt in the backend:

- Separated development and production dependencies into `requirements.txt` and `requirements-dev.txt`.
- Refactored the configuration in `app/config.py` to improve security and clarity.
- Simplified the CORS configuration in `main.py`.
- Introduced a `BaseService` class to handle common CRUD operations and reduce code duplication.
- Refactored `UserService`, `ExpenseService`, `GroupService`, and `AuthService` to use the `BaseService` and dependency injection.
- Updated all API routers to use dependency injection for the services.
- Updated the CI workflow to install development dependencies.
- Fixed an `ImportError` in `app/auth/__init__.py`.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
c51cf13 
for more information, see https://pre-commit.ci
@google-labs-jules
Refactor backend services to reduce technical debt
786338d 
This commit addresses several areas of technical debt in the backend:

- Separated development and production dependencies into `requirements.txt` and `requirements-dev.txt`.
- Refactored the configuration in `app/config.py` to improve security and clarity.
- Simplified the CORS configuration in `main.py`.
- Introduced a `BaseService` class to handle common CRUD operations and reduce code duplication.
- Refactored `UserService`, `ExpenseService`, `GroupService`, and `AuthService` to use the `BaseService` and dependency injection.
- Updated all API routers to use dependency injection for the services.
- Updated the CI workflow to install development dependencies.
- Fixed an `ImportError` in `app/auth/__init__.py`.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9ea41c9 
for more information, see https://pre-commit.ci
@google-labs-jules
Refactor backend services to reduce technical debt
5f8ebd9 
This commit addresses several areas of technical debt in the backend:

- Separated development and production dependencies into `requirements.txt` and `requirements-dev.txt`.
- Refactored the configuration in `app/config.py` to improve security and clarity.
- Simplified the CORS configuration in `main.py`.
- Introduced a `BaseService` class to handle common CRUD operations and reduce code duplication.
- Refactored `UserService`, `ExpenseService`, `GroupService`, and `AuthService` to use the `BaseService` and dependency injection.
- Updated all API routers to use dependency injection for the services.
- Updated the CI workflow to install development dependencies.
- Fixed an `ImportError` in `app/auth/__init__.py`.
- Fixed a patch in `tests/conftest.py`.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1dde2cc 
for more information, see https://pre-commit.ci
@monkscode
Merge branch 'main' into tech-debt-refactor
83df812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Devasy23 Devasy23 Awaiting requested review from Devasy23 Devasy23 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@monkscode