[Feat] 준비과정 추가/수정 하는 API호출 시 약속알림시간 업데이트되게 수정 #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
실패하는 테스트코드가 있어 PR이 자동으로 닫혔습니다. |
|
실패하는 테스트코드가 있어 PR이 자동으로 닫혔습니다. |
1 similar comment
|
실패하는 테스트코드가 있어 PR이 자동으로 닫혔습니다. |
jjjh02
reviewed
Jul 6, 2025
| } | ||
|
|
||
| private void updateAndRescheduleNotification(LocalDateTime newNotificationTime, NotificationSchedule notification) { | ||
| public void updateAndRescheduleNotification(LocalDateTime newNotificationTime, NotificationSchedule notification) { |
Contributor
There was a problem hiding this comment.
private에서 public으로 바꾸신 배경이 궁금한데 설명해주실 수 있을까요?
Contributor
Author
There was a problem hiding this comment.
preparationScheduleService에서 해당 메서드 사용하게 하기 위해서 변경했습니다.
(준비과정 수정 시에도 TaskScheduler의 스케줄을 리스케줄링해줘야해서 preparationScheduleService에서 해당 메서드 사용합니다)
Contributor
|
나머지 코드는 확인 완료했습니다~ 수고하셨습니다!! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
확인해야할 사항
Closed #226