Skip to content

Conversation

@liveforpresent
Copy link
Contributor

작업 내용

  • 인증/유저 관리 모듈 (auth, user, organization) 3개를 iam 모듈(Identity and Access Management)로 분리
  • chore: organization 분리 ~ chore: iam 모듈 생성까지는 전부 파일 이동에 관한 것.(리뷰할 때 재껴도 무방)
  • 일반 유저회원가입했다는 것을 더 잘 드러내기 위해 회원가입 이벤트명 수정(AuthCreated -> UserSignedUp)
  • 기관 정보 조회 구현. 단순 조회

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes the authentication and user management code by consolidating the auth, user, and organization modules into a new iam (Identity and Access Management) module. The refactoring improves code organization and clarifies the domain boundaries. Additionally, the PR renames the signup event from AuthCreatedEvent to UserSignedUpEvent to better represent that a general user has signed up, and implements organization information query functionality.

Key changes include:

  • Consolidation of auth/user/organization modules into the iam module with better separation of concerns
  • Event renaming: AuthCreatedEventUserSignedUpEvent to better reflect user signup semantics
  • Implementation of organization query endpoint (GET /organization) for retrieving organization information
  • Correction of typo across domain events: timesstamptimestamp
  • Package dependency updates to newer versions

Reviewed changes

Copilot reviewed 118 out of 151 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
iam/iam.module.ts New IAM module that aggregates auth, user, and organization modules
iam/auth/auth.module.ts Restructured auth module with updated imports
iam/user/user.module.ts Consolidated user module combining command and query functionality
iam/organization/organization.module.ts Restructured organization module with added query support
iam/auth/auth-user/domain/event/user-signed-up.event.ts Renamed event from AuthCreatedEvent to UserSignedUpEvent
iam/auth/auth-user/application/oauth-login/oauth-login.use-case.ts Updated to create users via CreateUserUseCase instead of emitting events
iam/organization/presentation/organization.controller.ts Added GET /organization endpoint for querying organization info
iam/organization/application/get/get-organization.use-case.ts New use case for retrieving organization information
src/analytics/application/auth-event.handler.ts Updated event handler to use UserSignedUpEvent
src/shared/core/domain/base.domain-event.ts Fixed typo: timesstamptimestamp
Multiple event files Applied timestamp typo fix across all domain events
package.json Updated various package versions to latest
Comments suppressed due to low confidence (1)

iam/auth/auth-user/application/oauth-login/oauth-login.use-case.ts:41

  • The comment was corrected from "소셜로그인 유저저 정보 가져오기" to "소셜로그인 유저 정보 가져오기" (removed duplicate "저"), but this spelling correction is already fixed in the updated code.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liveforpresent liveforpresent merged commit 39310ac into develop Dec 11, 2025
2 of 3 checks passed
@liveforpresent liveforpresent deleted the feature/user branch December 11, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants