Feature/organization #46
Conversation
…ub/EZPZ-BE into feature/organization
There was a problem hiding this comment.
Pull Request Overview
This pull request updates dependencies and refactors authentication-related code. The changes include:
- Dependency updates (major version bumps for AWS SDK, Angular DevKit, TypeScript ESLint, and other packages)
- Refactoring of authentication entities from
AuthEntityto separateAuthUserEntityandAuthOrganizationEntity - Addition of bcrypt for password hashing
- New organization module with command and query patterns
- Removal of OAuth provider logic from shared module
Reviewed Changes
Copilot reviewed 90 out of 101 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Major dependency updates including AWS SDK v3.888→v3.922, @Angular-devkit packages, and bcrypt addition |
| src/user/command/infrastructure/user.entity.ts | Updated auth relationship from AuthEntity to AuthUserEntity |
| src/user/command/infrastructure/user.command.repository.impl.ts | Updated populate field from 'auth' to 'authUser' |
| src/user/command/application/delete/delete.listener.ts | New event listener for auth deletion |
| src/user/command/application/delete/delete.handler.ts | Removed OAuth provider logic |
| src/shared/shared.module.ts | Removed OAuth and auth repository providers |
| src/shared/exception/custom-exception-code.ts | Added exception codes for AuthUser, AuthOrganization, and Organization |
| src/organization/* | New organization module with command/query pattern implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [CustomExceptionCode.AUTH_ORGANIZATION_NOT_FOUND]: { | ||
| status: HttpStatus.NOT_FOUND, | ||
| message: '[AuthOrganization] 해당 계정 정보가 존재하지 않습니다.', | ||
| //message: '[AuthOrganization] 해당 기관 인증 정보가 존재하지 않습니다.', |
There was a problem hiding this comment.
Remove commented-out code. If these alternative messages are needed, they should be documented separately or removed entirely.
| [CustomExceptionCode.AUTH_ORGANIZATION_INVALID_PASSWORD]: { | ||
| status: HttpStatus.UNAUTHORIZED, | ||
| message: '[AuthOrganization] 해당 계정 정보가 존재하지 않습니다.', | ||
| //message: '[AuthOrganization] 비밀번호가 올바르지 않습니다.', |
There was a problem hiding this comment.
Remove commented-out code. If these alternative messages are needed, they should be documented separately or removed entirely.
| @@ -1,5 +1,5 @@ | |||
| import { EventsHandler, IEventHandler } from '@nestjs/cqrs'; | |||
| import { AuthCreatedEvent } from 'src/auth/domain/event/auth-created.event'; | |||
| import { AuthCreatedEvent } from 'src/auth/auth-user/domain/event/auth-created.event'; | |||
There was a problem hiding this comment.
The import path contains 'infrasturcture' (typo) in the related AuthUserEntity import in user.entity.ts (line 2). Verify the actual directory name is 'infrastructure' not 'infrasturcture'.
작업 내용