Skip to content

Added handling for when the target element doesn't exist. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Newtons3Laws wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added handling for when the target element doesn't exist. #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions slidernav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,29 @@ $.fn.sliderNav = function(options) {
if(o.debug) $(slider).append('<div id="debug">Scroll Offset: <span>0</span></div>');
$('.slider-nav a', slider).on(opts.event, function(event){
var target = $(this).attr('alt');
var cOffset = $('.slider-content', slider).offset().top;
var tOffset = $('.slider-content '+target, slider).offset().top;
var height = $('.slider-nav', slider).height(); if(o.height) height = o.height;
var pScroll = (tOffset - cOffset) - height/8;
$('.slider-content li', slider).removeClass('selected');
$(target).addClass('selected');
$('.slider-content', slider).stop().animate({scrollTop: '+=' + pScroll + 'px'});
if(o.debug) $('#debug span', slider).html(tOffset);
var cOffset = $('.slider-content', slider).offset().top;
if (!$('.slider-content ' + target, slider).offset()) {
var index = o.items.indexOf(target.replace("#", ""));
var i = index - 1;
while (i >= 0){
if ($('.slider-content #' + o.items[i], slider).offset()) { target = "#" + o.items[i]; break; }
i--;
}
if (i == -1) {
i = index + 1;
while (i <= o.items.length - 1) {
if ($('.slider-content #' + o.items[i], slider).offset()) { target = "#" + o.items[i]; break; }
i++;
}
}
}
var tOffset = $('.slider-content ' + target, slider).offset().top;
var height = $('.slider-nav', slider).height(); if (o.height) height = o.height;
var pScroll = (tOffset - cOffset) - height / 8;
$('.slider-content li', slider).removeClass('selected');
$(target).addClass('selected');
$('.slider-content', slider).stop().animate({ scrollTop: '+=' + pScroll + 'px' });
if (o.debug) $('#debug span', slider).html(tOffset);
});
if(o.arrows){
$('.slider-nav',slider).css('top','20px');
Expand Down
14 changes: 7 additions & 7 deletions slidernav-min.js → slidernav.min.js
100755 → 100644
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.