fix: issue with module workers#3046
Merged
Bayheck merged 18 commits intoDevExpress:masterfrom Jan 12, 2026
Merged
Conversation
|
This pull request has been automatically marked as stale because it has not had any activity for a long period. It will be closed and archived if no further activity occurs. However, we may return to this pull request in the future. If it is still relevant or you have any additional information regarding it, please leave a comment and we will keep it open. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix an issue with module workers by detecting whether a worker is a module worker and using import() instead of importScripts() to load the hammerhead library.
- Adds an
isModule()detection function that attempts to callimportScripts()to determine if the worker context is a module worker - Conditionally uses
import()for module workers andimportScripts()for classic workers - Updates the worker initialization code in the script header template
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
aleks-pro
approved these changes
Jan 12, 2026
aleks-pro
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Describe the problem you want to address or the feature you want to implement.
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
Test in TestCafe: DevExpress/testcafe#8413
Closes DevExpress/testcafe#8251
Pre-Merge TODO