Skip to content

Scheduler: QUnit tests: ensure compatibility with Fluent and drop Generic theme testing #32278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksei-semikozov wants to merge 16 commits into
base: 26_1
Choose a base branch
from
Open

Scheduler: QUnit tests: ensure compatibility with Fluent and drop Generic theme testing #32278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d223d1e
Scheduler: switch from generic to fluent_blue_light theme
aleksei-semikozov Jan 22, 2026
e2acbcf
Merge branch '26_1' into Devextreme_2683
aleksei-semikozov Feb 5, 2026
cba0ccb
Fix icon test
aleksei-semikozov Feb 5, 2026
3bbccd1
fix(tests): update allDayAppointments tests to include maxAppointment…
aleksei-semikozov Feb 6, 2026
5151c1d
fix(tests): switch from generic_light to fluent_blue_light theme in a…
aleksei-semikozov Feb 6, 2026
9db58d4
fix(tests): switch from generic_light to fluent_blue_light theme in s…
aleksei-semikozov Feb 6, 2026
32a51d2
fix(tests): adjust height and width parameters in appointment scroll …
aleksei-semikozov Feb 6, 2026
547caca
fix(tests): add maxAppointmentsPerCell option to recurrence test
aleksei-semikozov Feb 6, 2026
3edf6c4
fix(tests): update appointment width in T712431 test to match expecte…
aleksei-semikozov Feb 6, 2026
7838ef9
fix(tests): switch from generic_light to fluent_blue_light theme in s…
aleksei-semikozov Feb 6, 2026
b8cdaf6
fix(tests): switch from generic_light to fluent_blue_light theme in s…
aleksei-semikozov Feb 6, 2026
0492e99
fix(tests): switch to fluent_blue_light theme and update expected rec…
aleksei-semikozov Feb 6, 2026
572f968
Implement feature X to enhance user experience and fix bug Y in module Z
aleksei-semikozov Feb 6, 2026
28863bd
fix(tests): add maxAppointmentsPerCell property to month view configu…
aleksei-semikozov Feb 7, 2026
8bc59e8
fix(tests): switch to fluent_blue_light theme and adjust position val…
aleksei-semikozov Feb 7, 2026
2ed7cba
fix(tests): switch to fluent_blue_light theme and adjust scroll posit…
aleksei-semikozov Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/devextreme/testing/tests/DevExpress.knockout/scheduler.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ require('integration/knockout');
const Scheduler = require('ui/scheduler');
const { waitAsync } = require('../../helpers/scheduler/waitForAsync.js');

require('generic_light.css!');
require('fluent_blue_light.css!');

if(QUnit.urlParams['nocsp']) {
QUnit.module('scheduler');
Expand Down Expand Up @@ -115,6 +115,16 @@ QUnit.test('T1282055: appointment collector renders correct', async function(ass
startDate: ko.observable('2021-06-01T16:30:00.000Z'),
endDate: ko.observable('2021-06-01T18:30:00.000Z')
},
{
text: 'Install New Router in Dev Room',
startDate: ko.observable('2021-06-01T16:30:00.000Z'),
endDate: ko.observable('2021-06-01T18:30:00.000Z')
},
{
text: 'Install New Router in Dev Room',
startDate: ko.observable('2021-06-01T16:30:00.000Z'),
endDate: ko.observable('2021-06-01T18:30:00.000Z')
},
{
text: 'Install New Router in Dev Room',
startDate: ko.observable('2021-06-01T16:30:00.000Z'),
Expand All @@ -124,7 +134,6 @@ QUnit.test('T1282055: appointment collector renders correct', async function(ass
views: ['month'],
currentView: 'month',
currentDate: new Date('2021-06-01T16:30:00'),
height: 300
};
Comment on lines 134 to 137
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scheduler options in this test no longer specify an explicit height. Since collector rendering can depend on the available viewport size, leaving height at the widget default can make the test more sensitive to future default changes / environment differences. Consider setting an explicit height here (as other KO scheduler tests do) to keep the assertion deterministic.

Copilot uses AI. Check for mistakes.
}

Expand Down
14 changes: 12 additions & 2 deletions packages/devextreme/testing/tests/DevExpress.ui.widgets.pivotGrid/export.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,20 @@ import { DataProvider } from '__internal/grids/pivot_grid/export/m_export';
import dateLocalization from 'common/core/localization/date';

import executeAsyncMock from '../../helpers/executeAsyncMock.js';
import { checkDxFontIcon, DX_ICON_XLSX_FILE_CONTENT_CODE } from '../../helpers/checkDxFontIconHelper.js';
import { DX_ICON_XLSX_FILE_CONTENT_CODE } from '../../helpers/checkDxFontIconHelper.js';

import 'ui/pivot_grid/ui.pivot_grid';
import 'generic_light.css!';
import 'fluent_blue_light.css!';

function checkDxFontIcon(assert, dxIconSelector, expectedIconCode) {
const FLUENT_BASE_ICON_SIZE = 20;

const iconBeforeElementStyle = getComputedStyle($(dxIconSelector).get(0), ':before');
assert.strictEqual(iconBeforeElementStyle.content.charCodeAt(1), expectedIconCode, `icon code (${dxIconSelector})`);
const iconElementStyle = getComputedStyle($(dxIconSelector).get(0));
assert.strictEqual(iconElementStyle.width, FLUENT_BASE_ICON_SIZE + 'px', `icon element width (${dxIconSelector})`);
assert.strictEqual(iconElementStyle.height, FLUENT_BASE_ICON_SIZE + 'px', `icon element height (${dxIconSelector})`);
}
Comment on lines +11 to +19
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checkDxFontIcon function has been duplicated from the helper file and modified to use FLUENT_BASE_ICON_SIZE (20px) instead of GENERIC_BASE_ICON_SIZE (18px). This duplication creates maintenance issues. Consider either updating the helper file to support both themes, or creating a separate theme-specific helper file that can be imported and reused across test files.

Copilot uses AI. Check for mistakes.

QUnit.testStart(function() {
const markup =
Expand Down
Loading
Loading