Conversation
dd68e24 to
897c71b
Compare
7e1cd67 to
59e831f
Compare
6139e7b to
21bb8d3
Compare
There was a problem hiding this comment.
I wouldn't use semicolons in group titles. And I would probably go with singular "Report Layout". You can create a layout, open a layout, save a layout. All those actions apply to a single layout. We're not listing multiple layouts in that group:
- Report Layout
- Display Report Dialogs
The form caption is a little confusing. I see this screenshot early in the article... and I assume that you can only work with a Table Report in this example. I assume that's the app title. We need to make it clear that it's just a name of the currently loaded report. So maybe do it like this:
"TableReport.repx - Report Layout"
There was a problem hiding this comment.
There's a strict limitation: app window is rather small and long captions don't fit. However, I'll do what I can to make it clear.
There was a problem hiding this comment.
I assume that you can only work with a Table Report in this example
The application can load any report file, not just the one included.
README.md
Outdated
|
|
||
| 1. Run the sample app and click **New Report**. | ||
| 1. Create a report layout (template) using tools available in the DevExpress [Report Designer](https://docs.devexpress.com/XtraReports/119176/web-reporting/web-end-user-report-designer). | ||
| 1. Click the hamburger button, select the **Save** option, enter a report template name, and close the dialog. |
There was a problem hiding this comment.
I would set the context here, because I was a bit confused about the hamburger button, as I don't see it on the screenshot.
| 1. Click the hamburger button, select the **Save** option, enter a report template name, and close the dialog. | |
| 1. Once you're done with changes in the **Report Designer** dialog, click the hamburger button, select **Save**, and enter a report template name. Close the dialog. |
BTW, it seems that I saved the report layout already, in this step. But then, in the next step, I have to click the Save button again (on the main app form). Should we explain why I need to go through the save process twice? Maybe we need to mention here, that this action doesn't actually save the report yet. But I'm not sure how it works.
There was a problem hiding this comment.
Hmm. Maybe we should use completely distinct terms for file operations, such as Import from file and Export to file. This naming would highlight the difference from saving layouts in a Report Designer.
However, the methods to import and export layouts are still LoadFromFile and SaveToFile, as the Layout property inherits a simple TString.
b8ed37f to
d3c24ec
Compare
- Fix the SQLite connection string: correct path to nwind.db. - Before saving a report, pass the name to the file save dialog. - Assign a name and icon to the application. - Clarify error messages in message boxes. - Always update the application caption when report changes. - Extract a method to load a report and update the application caption.
- Fix the SQLite connection string: correct path to nwind.db. - Before saving a report, pass the name to the file save dialog. - Extract a method to load a report and update the application caption. - Check the file existence before opening a report. - Assign a name and icon to the application. - Clarify error messages in message boxes. - Always update the application caption when report changes. - Rename the project to match Delphi project name.
0a468c3 to
8fcaed1
Compare
54be2da to
c47aea8
Compare
Co-authored-by: Dmitry Eliseev <81766219+dmitry-eliseev-devexpress@users.noreply.github.com> Co-authored-by: Vladimir Abadzhev <vladimira@devexpress.com>
99f3f33 to
134db07
Compare
readme: Update instructions
Readme preview: https://github.com/DevExpress-Examples/vcl-reports-store-layout-template-file/blob/25.2.3-volynkin-update-examples/README.md
repo: Add a Delphi/C++Builder gitignore file
delphi/cpp-builder: Update and clarify the example
before:
after: