Skip to content

Restore resilient HtmlAgilityPack.dll resolution in Export-GHEntraFido #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Restore resilient HtmlAgilityPack.dll resolution in Export-GHEntraFido #723

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b3e7a
Initial plan
Copilot May 12, 2026
6f85eec
Apply PR 722 changes: PSParseHTML guard, module-path-first DLL lookup…
Copilot May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions Scripts/Export-GHEntraFido.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,30 @@ Function Export-GHEntraFido {
[string]$Url
)

if (-not (Get-Module -Name PSParseHTML)) {
Import-Module PSParseHTML -ErrorAction Stop
}

if (-not ('HtmlAgilityPack.HtmlDocument' -as [type])) {
$dll = Get-ChildItem -Path $HOME -Recurse -Filter HtmlAgilityPack.dll -ErrorAction SilentlyContinue |
Select-Object -First 1
$module = Get-Module PSParseHTML
$dll = $null

if (-not $dll) {
throw "HtmlAgilityPack.dll not found. Ensure the dependency is installed before running Export-GHEntraFido."
}
if ($module -and $module.ModuleBase) {
$dll = Get-ChildItem -Path $module.ModuleBase -Recurse -Filter HtmlAgilityPack.dll -ErrorAction SilentlyContinue |
Select-Object -First 1
}

Add-Type -Path $dll.FullName
}
if (-not $dll) {
$dll = Get-ChildItem -Path $HOME -Recurse -Filter HtmlAgilityPack.dll -ErrorAction SilentlyContinue |
Select-Object -First 1
}

$response = Invoke-WebRequest -Uri $Url -UseBasicParsing
$htmlContent = $response.Content
if (-not $dll) {
throw "HtmlAgilityPack.dll not found. Ensure the dependency is installed before running Export-GHEntraFido."
}

$htmlDocument = New-Object HtmlAgilityPack.HtmlDocument
$htmlDocument.LoadHtml($htmlContent)
Add-Type -Path $dll.FullName
}

# Fetch the webpage content
$response = Invoke-WebRequest -Uri $Url -UseBasicParsing
Expand Down
Loading