Fix HtmlAgilityPack.dll resolution: scope lookup to PSParseHTML module directory

[Copilot]

Export-GHEntraFido.ps1 failed on GitHub-hosted runners because it searched $HOME recursively for HtmlAgilityPack.dll — a path that doesn't exist on fresh runners — rather than loading the DLL bundled with the already-installed PSParseHTML module.

Changes

• Scripts/Export-GHEntraFido.ps1
  • Guard-import PSParseHTML at function entry if not already in session
  • Replace $HOME recursive scan with a targeted lookup under (Get-Module PSParseHTML).ModuleBase:

    if (-not ('HtmlAgilityPack.HtmlDocument' -as [type])) {
        $module = Get-Module PSParseHTML
        $dll = Get-ChildItem -Path $module.ModuleBase -Recurse -Filter HtmlAgilityPack.dll -ErrorAction SilentlyContinue |
            Select-Object -First 1
        if (-not $dll) {
            throw "HtmlAgilityPack.dll not found under PSParseHTML module path. Ensure PSParseHTML is installed before running Export-GHEntraFido."
        }
        Add-Type -Path $dll.FullName
    }

  • Remove duplicate Invoke-WebRequest + LoadHtml calls that existed back-to-back in the original

Original prompt

Update pull request #721 in repository DevClate/EntraFIDOFinder to fix the remaining GitHub Actions failure.

Context:

• PR URL: Fix CI: replace brittle HtmlAgilityPack.dll search with PSParseHTML module import #721
• PR title: Fix CI: replace brittle HtmlAgilityPack.dll search with PSParseHTML module import
• The PR currently changes:
  • .github/workflows/GHMerge.yml
  • Scripts/Export-GHEntraFido.ps1
• The current head commit is d1228aa7fb8812b6fa9d2fa0c7e29a8688a0430d on branch copilot/fix-gh-actions-job-failure.

Observed failure:

• GitHub Actions job merge-fido-data still fails on the PR head commit.
• Failing job: 75535652792
• Failure message from logs:
  • Failed to fetch data from URL: HtmlAgilityPack.dll not found. Ensure the dependency is installed before running Export-GHEntraFido.

Root cause still present:

• Scripts/Export-GHEntraFido.ps1 no longer recursively scans $HOME, but it still directly instantiates HtmlAgilityPack.HtmlDocument.
• Importing PSParseHTML alone does not guarantee the HtmlAgilityPack type is already resolvable in the session.

Required change:

• Update Scripts/Export-GHEntraFido.ps1 so it robustly ensures HtmlAgilityPack.HtmlDocument is available after importing PSParseHTML.
• Preferred minimal approach:
  • Import PSParseHTML if not already loaded.
  • If the type HtmlAgilityPack.HtmlDocument is still unavailable, locate HtmlAgilityPack.dll under the installed PSParseHTML module directory ((Get-Module PSParseHTML).ModuleBase) and load it with Add-Type.
  • Do not scan all of $HOME.
  • Preserve the existing HTML parsing behavior and table extraction logic.
• Keep the workflow hardening already in the PR unless the agent finds a more targeted improvement.

Acceptance criteria:

• The script no longer depends on a brittle global file search.
• The script can run successfully on GitHub-hosted runners where PSParseHTML is installed in the workflow.
• The PR branch is updated with the targeted patch.
• After updating, allow GitHub checks to run and report whether the checks still fail or not.

Please update the existing PR branch rather than creating a separate unrelated change.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Please find a solution for failing job 75535652792. Use the logs, job definition, and any referenced files where the failure occurred. Keep your response focused on the solution and include code suggestions when appropriate.

Assistant: The failure is caused by Export-GHEntraFido trying to instantiate HtmlAgilityPack.HtmlDocument, but the assembly is not available at runtime:

• Failing call chain:
  • Merge-GHFidoData calls Export-GHEntraFido at Scripts/Merge-GHFidoData.ps1
  • Export-GHEntraFido creates the type at Scripts/Export-GHEntraFido.ps1
• Workflow context:
  • The job installs/imports PSParseHTML before running the script at .github/workflows/GHMerge.yml
  • It imports the module again before dot-sourcing scripts at .github/workflows/GHMerge.yml

Solution

Make Export-GHEntraFido.ps1 stop depending on direct construction of the HtmlAgilityPack .NET type. Use the parser already exposed by PSParseHTML, or parse the response HTML with PowerShell-native HTML handling instead of New-Object HtmlAgilityPack.HtmlDocument.

Recommended fix

Replace the HtmlAgilityPack object creation and node traversal in Scripts/Export-GHEntraFido.ps1 with a module-level parser call.

A practical patch is:

Function Export-GHEntraFido {
    [CmdletBinding()]
    param (
        [Parameter(Mandatory = $true)]
        [string]$Url
    )

    Import-Module PSParseHTML -ErrorAction Stop

    $response = Invoke-WebRequest -Uri $Url
    $htmlContent = $response.Content

    # Parse HTML through the module instead of directly newing HtmlAgilityPack types
    $htmlDocument = ConvertFrom-Html -Content $htmlContent

    $tableNodes = $htmlDocument.SelectNodes("//table")

    $targetTableNode = $null
    foreach ($tableNode in $tableNodes) {
        $headers = $tableNode.SelectNodes(".//thead/tr/th") | ForEach-Object { $_.InnerText.Trim() }
        if ($headers -contains "Description" -and $headers -contains "AAGUID") {
            $targetTableNode = $tableNode
            break
        }
    }

    if ($null -eq $targetTableNode) ...

</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

*This pull request was created from Copilot chat.*
>

[DevClate]

Request changes

The failing merge-fido-data check is still hitting:

Failed to fetch data from URL: HtmlAgilityPack.dll not found. Ensure the dependency is installed before running Export-GHEntraFido.

From the current PR head, I’m not seeing the fix described in the PR body in Scripts/Export-GHEntraFido.ps1. The script still appears to only search $HOME for HtmlAgilityPack.dll and then throw if nothing is found.

I’m not seeing:

the PSParseHTML import guard
the first lookup under (Get-Module PSParseHTML).ModuleBase
the fallback sequence of module path first, then $HOME
Since that logic doesn’t appear to be present yet, this PR doesn’t seem to implement the intended CI fix. Please push the intended DLL-resolution change to this PR branch and re-run checks.

[DevClate]

Request changes

The failing merge-fido-data check is still hitting:

Failed to fetch data from URL: HtmlAgilityPack.dll not found. Ensure the dependency is installed before running Export-GHEntraFido.

From the current PR head, I’m not seeing the fix described in the PR body in Scripts/Export-GHEntraFido.ps1. The script still appears to only search $HOME for HtmlAgilityPack.dll and then throw if nothing is found.

I’m not seeing:

the PSParseHTML import guard the first lookup under (Get-Module PSParseHTML).ModuleBase the fallback sequence of module path first, then $HOME Since that logic doesn’t appear to be present yet, this PR doesn’t seem to implement the intended CI fix. Please push the intended DLL-resolution change to this PR branch and re-run checks.

@copilot

[Copilot]

Request changes

The failing merge-fido-data check is still hitting:...

The fix has been pushed in commit 77e27a2 on PR #722 (branch copilot/fix-gh-actions-job-failure-again). PR #721 was closed, so the work was continued there. The script now:

1. Guard-imports PSParseHTML if not already loaded
2. Checks if HtmlAgilityPack.HtmlDocument is resolvable — if not, locates the DLL under (Get-Module PSParseHTML).ModuleBase and loads it with Add-Type
3. No longer scans $HOME

Please check PR #722 for the applied changes.