Signup#7
Open
Ogenyi25 wants to merge 3 commits intoDevCAbuja:devfrom
Open
Conversation
Contributor
Ogenyi25
commented
Aug 9, 2019
Ogenyi25
commented
- Added views for signup page.
- Made few changes to the login page
Collaborator
|
Please fix your merge conflicts |
samie820
requested changes
Aug 18, 2019
| .icon { | ||
| margin: 20px; | ||
| } | ||
| .input-group { |
There was a problem hiding this comment.
This is also a kind of repetition, don't you think it's possible to move this common style definition into its own .scss file, inputs.scss for example?
| </div> | ||
| <br /> | ||
| <div className="input-group"> | ||
| <img src={PasswordIcon} alt="ui" /> |
There was a problem hiding this comment.
Better alt description will really help accessibility, same for other image tags.
| <img className="d-block w-100" src={DevC} alt="Fifth slide" /> | ||
| </div> | ||
| <div className="carousel-item"> | ||
| <img className="d-block w-100" src={DevC} alt="Sixth slide" /> |
There was a problem hiding this comment.
Same here also (update alt description e.g alt=" student holing a book, used as the sixth slide")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.