Skip to content

fix(analytics): uniqueViewers now uses COUNT(DISTINCT viewer_id) instead of inflated groupBy #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Srejoye wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(analytics): uniqueViewers now uses COUNT(DISTINCT viewer_id) instead of inflated groupBy #449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions apps/backend/src/routes/analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,14 @@ export async function analyticsRoutes(
// Count unique viewers
// In raw SQL this is `SELECT COUNT(DISTINCT viewer_id) FROM card_views WHERE owner_id = ?`
// Prisma group-by as workaround:
const uniqueViewersQuery =
await app.prisma.cardView.groupBy({
by: ['viewerId', 'viewerIp'],
where: { ownerId: userId },
});

const uniqueViewers = uniqueViewersQuery.length;
const uniqueViewersQuery = await app.prisma.$queryRaw<[{ count: bigint }]>`
SELECT COUNT(DISTINCT viewer_id) AS count
FROM card_views
WHERE owner_id = ${userId}
AND viewer_id IS NOT NULL
`;

const uniqueViewers = Number(uniqueViewersQuery[0]?.count ?? 0);

return {
totalViews,
Expand Down