Add up namespace via overlay#9
Conversation
📝 WalkthroughWalkthroughThe PR restructures the flake overlay to expose an ChangesNamespace migration from pkgs.lib. to pkgs.up.**
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
17-17:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUpdate setup text to
pkgs.up.*namespace.Line 17 still references
lib.mkTaskRunner/lib.mkProcessTree, but the overlay now exposes helpers underpkgs.up.*. This setup sentence is currently misleading.Suggested doc fix
-This provides the [`lib.mkTaskRunner`](`#task-runners`), [`lib.mkProcessTree`](`#process-trees`), and other functions that you'll see below. +This provides the [`pkgs.up.mkTaskRunner`](`#task-runners`), [`pkgs.up.mkProcessTree`](`#process-trees`), and other functions that you'll see below.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` at line 17, Update the README setup sentence that references lib.mkTaskRunner and lib.mkProcessTree to use the new overlay namespace pkgs.up.* (e.g., replace mentions of lib.mkTaskRunner and lib.mkProcessTree with pkgs.up.mkTaskRunner and pkgs.up.mkProcessTree or the appropriate pkgs.up helper names) so the documentation matches the current exports.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@README.md`:
- Line 17: Update the README setup sentence that references lib.mkTaskRunner and
lib.mkProcessTree to use the new overlay namespace pkgs.up.* (e.g., replace
mentions of lib.mkTaskRunner and lib.mkProcessTree with pkgs.up.mkTaskRunner and
pkgs.up.mkProcessTree or the appropriate pkgs.up helper names) so the
documentation matches the current exports.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a341529e-7e3e-4b54-bc94-45a95a790799
📒 Files selected for processing (3)
README.mdlib/benchmark.nixlib/default.nix
✅ Files skipped from review due to trivial changes (1)
- lib/benchmark.nix
Neither
pkgs.mk*norpkgs.lib.mk*feels quite right. I like the idea of providing apkgs.upnamespace via the overlay.Summary by CodeRabbit
Documentation
Refactor