Skip to content

fixup: don't include linux-only drvs if not on linux#496

Merged
cole-h merged 1 commit into
mainfrom
fixup-skip-unsupported
Jun 12, 2026
Merged

fixup: don't include linux-only drvs if not on linux#496
cole-h merged 1 commit into
mainfrom
fixup-skip-unsupported

Conversation

@cole-h

@cole-h cole-h commented Jun 12, 2026

Copy link
Copy Markdown
Member

Motivation

Context

Summary by CodeRabbit

  • Chores
    • Updated build configuration to conditionally include static package variants. Static builds are now only generated for applicable platforms based on system configuration.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1b2bf4ab-c650-47a7-8b7b-a4caceea6cf0

📥 Commits

Reviewing files that changed from the base of the PR and between 01094d3 and 1471e14.

📒 Files selected for processing (1)
  • flake.nix

📝 Walkthrough

Walkthrough

The PR gates the -static package derivation in the Nix flake based on the linuxOnly flag and host platform, wrapping it in lib.optionalAttrs to conditionally include it only when appropriate for the target system.

Changes

Platform-conditional static packages

Layer / File(s) Summary
Platform-gated static derivation
flake.nix
The static package attribute is wrapped in lib.optionalAttrs to conditionally include it based on linuxOnly and native stdenv host platform, ensuring -static derivations are only built when the configuration and target system allow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A static build hops through the gates,
Only on Linux when the flag awaits,
Platform-aware derivations now flow,
Conditional paths let the packages grow! 📦

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: conditionally including linux-only static package derivations only on Linux systems, matching the flake.nix modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixup-skip-unsupported

Comment @coderabbitai help to get the list of available commands and usage tips.

@cole-h cole-h enabled auto-merge June 12, 2026 00:11
@github-actions

Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to pull request June 12, 2026 00:14 Inactive
@cole-h cole-h added this pull request to the merge queue Jun 12, 2026
Merged via the queue into main with commit 2a5c930 Jun 12, 2026
30 checks passed
@cole-h cole-h deleted the fixup-skip-unsupported branch June 12, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants