[feature] SC-166737/improve app proxy security by restricting where token replacements can go#72
Open
HappyPaul55 wants to merge 1 commit intomainfrom
Conversation
…oken replacements can go
There was a problem hiding this comment.
Pull Request Overview
This PR enhances OAuth security in the Copper app by adding settingsInjection configuration to proxy endpoints, enabling controlled injection of sensitive settings like client_id and client_secret into OAuth requests.
- Added
settingsInjectionconfiguration to two proxy whitelist endpoints - Configured the OAuth endpoint to inject
client_idandclient_secretinto request bodies - Prepared the API endpoint with an empty
settingsInjectionobject for future use
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Build for commit 78f9849 deployed to: https://copper-pr-72.ci.next.deskprodemo.com URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
manifest.jsonfile to support injecting sensitive configuration values into requests for OAuth integration. The main focus is on adding asettingsInjectionfield to relevant endpoints, which allows the system to automatically include theclient_idandclient_secretin the request body, improving flexibility and security in handling authentication.Enhancements to OAuth endpoint configuration:
settingsInjectionfield to the OAuth endpoint configuration, enabling automatic injection of settings such asclient_idandclient_secretinto the request body.settingsInjectionobject to another endpoint, preparing it for future configuration injection support.