Open
Conversation
Fix error grammar in file Readme.md
strcpy_P not needed for ESP8266/2.5.0-beta2 sdk
Use of incorrect case in the Arduino Playground URL resulted in a redirect to the Playground home page instead of the expected Time library page.
Fix bad URL in library.properties
This now compiles on ESP platform v2.4.2 and v2.5.2 on Arduino IDE 1.8.9 and 1.9.0 beta. I've also uploaded to example to ESP8266 to double check and works fine.
Update DateStrings.cpp
Added ESP32 Arch
Update Readme.md - minor text alignment
Update Readme.md - put code-quotes around some types/identifiers
The current (old) description claimded that the DS1307RTC library is part of the download bundle, which is not (no longer?) the case. Instead pointing to following now: https://github.com/PaulStoffregen/DS1307RTC Change-Id: I28b0c71398e56d50de0c786e4dee97d28f408481
Change-Id: Ia05c370e8f09b75dddf11cf2aa8b5de4c21bd45d
Few minor updates to the Readme.md file
The Arduino library.properties specification gives the `includes` entry: * **includes - (available from Arduino IDE 1.6.10) (optional)** a comma separated list of files to be added to the sketch as #include <...> lines. This property is used with the "Include library" command in the Arduino IDE. If the includes property is missing, all the header files (.h) on the root source folder are included. Adding this will prevent both Time.h and TimeLib.h from being included in the IDE with the include library menu option.
Added includes to properties file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.