Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26e813923c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 2. Run an LLM fill pass to replace placeholder bullets in each `resume.tex` before compile. | ||
| 3. Run `career_tailor` once per batch. | ||
| 4. Use only `career_tailor.successful_items` for `finalize_resume_batch`. |
There was a problem hiding this comment.
career_tailor before requiring resume.tex edits
This workflow order is not executable for new shortlist items: step 2 requires editing data/applications/<slug>/resume/resume.tex, but that file is only created when career_tailor runs (see the tool contract and process_item_tailoring materialization step in mcp-server-python/tools/career_tailor.py). On a first pass there is nothing to edit, so the skill either blocks immediately or proceeds to career_tailor with placeholders and gets item-level validation failures, preventing successful_items from reaching finalize_resume_batch.
Useful? React with 👍 / 👎.
| Preflight check before `career_tailor`: | ||
|
|
||
| ```bash | ||
| rg -n "WORK-BULLET-POINT-|AI-PROJECT-BULLET-|BE-PROJECT-BULLET-" data/applications/*/resume/resume.tex |
There was a problem hiding this comment.
rg on a glob that may match no files
This preflight command fails on fresh runs because data/applications/*/resume/resume.tex often matches nothing before any tailoring workspace exists, and ripgrep treats the resulting literal/nonexistent path as an OS error (exit code 2) rather than “no matches.” That makes the documented “Expected: no matches” state unreachable for first-time batches and can halt the flow before career_tailor bootstraps artifacts.
Useful? React with 👍 / 👎.
1 participant
No description provided.