Skip to content

Codex/scraper mcp#4

Merged
DengNaichen merged 3 commits intomainfrom
codex/scraper-mcp
Feb 7, 2026
Merged

Codex/scraper mcp#4
DengNaichen merged 3 commits intomainfrom
codex/scraper-mcp

Conversation

@DengNaichen
Copy link
Owner

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 891ed98cd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +906 to +907
if len(terms) == 0:
raise create_validation_error("Invalid terms: cannot be empty array")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Bound scrape term count during validation

validate_scrape_terms() only rejects empty input and then accepts any list length, so callers can submit arbitrarily large term arrays that trigger unbounded per-term network/database work in a single request. This is a resource-safety regression for the new tool and should be blocked at validation time with a max term count.

Useful? React with 👍 / 👎.

@DengNaichen DengNaichen merged commit 750c08a into main Feb 7, 2026
4 of 8 checks passed
@DengNaichen DengNaichen deleted the codex/scraper-mcp branch February 7, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments