- Add option where IG source term uses mean wave energy Eprev_ig in s…#283
Draft
- Add option where IG source term uses mean wave energy Eprev_ig in s…#283
Conversation
…ource term calculation instead of bin dependent eeprev_ig, thanks to suggestion of Yasmine - results look promising
…ave energy, instead of the bin one - Works, but not sure whether it is better than snapwave_ig_opt =3
…king point when IG waves should be released - Determined based on delta Dw
…nt waves start breaking (Qb > 1%)
…Zijlema (2022) - Does at first glance not seem to influence much/enough
…h) where waves start breaking - not sure this is the best place to do this...
- Add local wave height water depth ration 'gam' to his output - For now with Qb determined based on upwind point - For now with taking maxval over itheta for both qb and gam output
…king is started the velocity of cg_ig is changed to sqrt(g*h) - In igopt 8 for now set only point 'k' to sqrt(g*h), not yet k1 and k2, to be discussed
…l over a range of different cases
- Does not work well in shadow zones currently, question is mostly how to determine Sxx_cons
… on integrated energies, and at the redistributing them over bins like for Dw - Result pretty much the same as before with igopt 9
…cig as alrready mutliplied by ee_itheta,k) and in 'B' term - ig opt 12 can be the working version in R
- Results don't look good yet, not sure whats wrong, it is like Snapwave trunk commit of Dano of 03-04-2025
…alue to multiply with snapwave_gamma factor for estimating the incident wave breaking point initiation, and setting the srcig to 0 - description: factor times gamma that is used to determine the maximum incident wave breaking point in the surf zone using local incident wave height over water depth ratio, among others used to set the IG source term to 0 shallower than this point - Now include the /sqrt(2) so that value becomes gam (Hrms based) > 0.47 * gamma - used for ig_opt >= 11
…lead to issues, therefore remove for ig_opt 12&12
- Only keep the (already precleaned) ig_opt 11&12 version of subroutine determine_infragravity_source_sink_term - Add description qb_local, gam_local
…e_sink_term' - Rename the main option 11 to ig_opt = 1 (=the default) - For now keep also option 11 for ease, but exactly the same as 1 - Option 2 is name the same as ig_opt 1, but without using the conservative shoaling (as before) - ig_opt = 3 is the same as option 1, but with including the cg_ig adjustment - turn off ig_opt 12 - currently does not work, need to further check moving from R- to B-term
… is a more gradual decreasing of srcig to 0 . - 'transition_factor' is controled around 'gamma_fac_br * gamma' as center - And width controlled by transition_factor_width > 0.005 seems to work well - With this, found best gamma_fac_br to be 0.45 now - adjusted default value
…with limiting beta_local to 0.07, as suggested by Maarten for steep slopes
…transitioned so that for beta 0.05 the factor is 0.45 (default snapwave_gamma_fac_br), but for steeper coasts (beta > 0.07) it is fully 1.0 (no reduction of srcig) because then driven by breakpoint forcing
- Remove some of the options - let ig_opt =1 &2 be the simple one without smooth srcig to 0 functions
… for addition to alphaig - Values set to initial estimate by Yasmine - Tested to work for 1:3 test - Todo: make factors user definable
…coded values of before. Result is therefore the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ource term calculation instead of bin dependent eeprev_ig, thanks to suggestion of Yasmine - results look promising